prepare-root: Handle non-AB aboot properly #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otcore_get_ostree_target() should set is_aboot for android boot systems, but currently it only does this on A/B boot systems, not single-boot-partition systems. Fix this by setting it in the second case.
ericcurtin
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
There's three types of aboot I guess:
- Normal AB switching mode
- androidboot.slot_suffix=_a but no AB switching tool available, so we always boot into a
- similar to 2, but we have specified a root= karg, booting in development mode, causing androidboot.slot_suffix to not be set at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otcore_get_ostree_target() should set is_aboot for android boot systems, but currently it only does this on A/B boot systems, not single-boot-partition systems. Fix this by setting it in the second case.