prepare-root: A few cleanups #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a minor cleanup.
|
test-concurrency.py strikes again! |
|
Oh, and clang-format |
Now that we link to libotutil (and glib) we don't need separate handling for conditionalizing on the presence of systemd. Further, there's no value in `sd_journal_send(MESSAGE=)` over just printing to stdout.
This logic got pushed down into libcomposefs.
cgwalters
force-pushed
the
otcore-cfs-constants
branch
from
0131ff2
to
18cc447
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an internal constant for the composefs image name
Just a minor cleanup.
prepare-root: Use otutil and g_print
Now that we link to libotutil (and glib) we don't need separate
handling for conditionalizing on the presence of systemd.
Further, there's no value in
sd_journal_send(MESSAGE=)overjust printing to stdout.
prepare-root: Drop unused verity flag querying
This logic got pushed down into libcomposefs.