-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the timezone used for saving meetups and scheduling reminders #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@starkah Thanks for the PR 😄 . Requested some changes. Rest LGTM
@sidntrivedi012 @DelusionalOptimist What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daemon1024 @DelusionalOptimist thanks for pointing out the necessary changes. I'm on it. |
@DelusionalOptimist Wouldn't it be more easier for the user if the reminder was in it's local time zone?
|
@starkah Note that the users are the members of OSDC and IST would be the local timezone for em :) But the bot can be deployed anywhere and the timezone of the developer's local system or any environment shouldn't be a dependency. |
@daemon1024 Makes sense. I'll try to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits rest LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work @starkah. 🚀
Fixes #41