Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling #43

Open
daemon1024 opened this issue Oct 15, 2020 · 2 comments · May be fixed by #62
Open

Error handling #43

daemon1024 opened this issue Oct 15, 2020 · 2 comments · May be fixed by #62
Assignees
@OgmaJ
Labels
bug Something isn't working help wanted Extra attention is needed telegram bot

Comments

@daemon1024
Copy link
Member

daemon1024 commented Oct 15, 2020 •
edited
Loading

Describe the bug

There are lots of edge cases and instances where bot crashes due to some unexpected syntax or error.

Example : Unexpected syntax in /addmeetup

Expected behavior

The bot shouldn't crash instead it should respond with something like " Unexpected behaviour, please try again "

** Additional Context **

We are using log.Fatal / log.Fatalln when an error occurs. This causes the program to call os.exit(1) which is an undesirable behaviour.

Instead we should log.Print the errors as well as a bot response for the same.
@daemon1024 daemon1024 added bug Something isn't working help wanted Extra attention is needed labels Oct 15, 2020
@daemon1024 daemon1024 mentioned this issue Oct 17, 2020
Merged
@OgmaJ
Copy link

OgmaJ commented Nov 10, 2020

@daemon1024 : let me pick this one :

  • removing log.Fatal
  • convert log.Print & send a error message

@daemon1024
Copy link
Member Author

@OgmaJ sure.

https://github.com/osdc/bots/blob/master/telegram-bot/meetup.go#L139-L141

This may help you out.

OgmaJ added a commit to OgmaJ/bots that referenced this issue Nov 10, 2020
@OgmaJ
Error handling osdc#43 : migration from fatal to println
ac46a8c 
 - remove fmt to log package for printing issue
OgmaJ added a commit to OgmaJ/bots that referenced this issue Nov 10, 2020
@OgmaJ
Error handling osdc#43 : migration from fatal to println
56d6652 
 - remove fmt to log package for printing issue
@daemon1024 daemon1024 linked a pull request Nov 11, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OgmaJ OgmaJ

Labels
bug Something isn't working help wanted Extra attention is needed telegram bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error handling #43 : migration from fatal to println OgmaJ/bots
2 participants
@OgmaJ @daemon1024