-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof of concept of an ssp helper for jinja #1684
base: develop
Are you sure you want to change the base?
Conversation
Fix type of return value Add more helpers Don't use subscript operator on what could be an empty list Add a diagram link retrieval Retrieve the given diagram's href Add as_list as top-level lut option for jinja Make safe_retrieval more safe Remove as_list Remove exception from safe_retrieval logging Clarify that first_array_entry could return None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahearn Post community meeting, I wanted add some thoughts here and see if they aligned with what you got out of the meeting:
Does this sound right? |
Yes, it does. Where I was unclear after the meeting was what the timeline for that was, and whether this PR should be improved to either be a short-term gap filler or a start of that work, or if it should be closed and serve only as a proof-of-concept/early use case example. Do you have thoughts on that? |
Good question. Since the timeline of the effort we disucssed yesterday is still undefined, I don't think we should make it a blocker for this work. Maybe breaking up into two distinct PRs may help with this.
What do you think? @butler54 @vikas-agarwal76 Please chime in if you disagree. |
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Opening this PR for feedback on approach. I was in need of these types of methods while writing a document-based SSP using
trestle author jinja
to pull the appropriate data out of my OSCAL SSP.This obviously will need tests to be added before merging.
Key links:
Before you merge