Move environment hook to pkg pt2

[schuellerf]

This pull request includes:

• [✔️] adequate testing for the new functionality or fixed issue
• [✔️] adequate documentation informing people about the change such as
  • extended make help

functionally this PR does not change anything. It just

• moves the environment_hook to pkg/splunk_logger so it can be used by image-builder too
• unify behavior of github action and local test (by calling make from github action)
• enables testing of pkg/splunk_logger (this was never tested I guess)
• introduces make coverage-report as this is generated anyway and can be reviewed by humans like this

followup of #4301

[schuellerf]

just out of curiosity - is the coverage.txt (of the github actions) used somewhere?

[achilleas-k]

just out of curiosity - is the coverage.txt (of the github actions) used somewhere?

We have a coverity action running on a schedule but I don't know if it uses that file or does it's own thing.

[schuellerf]

Thanks @croissanne for creating the newly split repo
I'll take care of
osbuild/splunk_logger#1
which is a little more than just fixing a line :-/

can we merge this first (as this is waiting a while now)?
I'll immediately fix the new splunk_logger package afterwards (also here and in image-builder)

[mvo5]

Thanks @croissanne for creating the newly split repo I'll take care of osbuild/splunk_logger#1 which is a little more than just fixing a line :-/

can we merge this first (as this is waiting a while now)? I'll immediately fix the new splunk_logger package afterwards (also here and in image-builder)

Fwiw, I'm fine with merging this first but also curious - what is the extra work (beyond fixing the go.mod)? The workflow or is there more to it?

[schuellerf]

Fwiw, I'm fine with merging this first but also curious - what is the extra work (beyond fixing the go.mod)? The workflow or is there more to it?

the things to be done are being collected in osbuild/splunk_logger#1 right now

[thozza]

Changes look fine to me. What's the end result WRT waiting for the external pkg to be used?

[schuellerf]

Changes look fine to me. What's the end result WRT waiting for the external pkg to be used?

Not sure if I got your question right, but the splunk_logger is also used by image-builder
or did you mean factoring out splunk_logger that's just more clean but can be done before or after this PR

[schuellerf]

Obsolete due to #4316

[thozza]

Changes look fine to me. What's the end result WRT waiting for the external pkg to be used?

Not sure if I got your question right, but the splunk_logger is also used by image-builder or did you mean factoring out splunk_logger that's just more clean but can be done before or after this PR

I meant using the package from its own git repository and not from within this one.

[schuellerf]

I meant using the package from its own git repository and not from within this one.

Just makes Makefile, tests etc more clumsy and less obvious to maintain