-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building images from ostree containers #272
Add support for building images from ostree containers #272
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0464233 - Browse repository at this point
Copy the full SHA 0464233View commit details -
osbuild: add ostree.deploy.container stage
Creates an org.osbuild.ostree.deploy.container stage. Validates the options with a regular expression that matches the schema. Takes a container as input. Validates the length of the input references to be exactly 1. Also added tests for the validators for options and inputs. See osbuild/osbuild#1402
Configuration menu - View commit details
-
Copy full SHA for d7058d3 - Browse repository at this point
Copy the full SHA d7058d3View commit details -
manifest: only set one ostree commit in OSTreeDeployment
The pipeline either way only supported one ostree commit, enforced when adding the resolved commits to the pipeline during serializeStart() and by checking the array length during serialize(). To simplify the requirement and avoid potential confusion when reading the struct itself, replace the array on the pipeline struct definition with a single commit spec (pointer) and keep the len == 1 check in the serializeStart() function that, by its interface, must accept an array. Also document the commit fields for OSTreeDeployment. These are private, so they wont show up in public API docs, but it's still useful to have them documented in the code.
Configuration menu - View commit details
-
Copy full SHA for 0bab73b - Browse repository at this point
Copy the full SHA 0bab73bView commit details -
manifest: add a container source to OSTreeDeployment
Support a container source for OSTreeDeployment as an alternative to the ostree commit source. Currently, if a container is defined, it fails with an error. The commit source and the container source are now both pointers since they can be unset, but (will) we need to make sure at least one is set when serializing.
Configuration menu - View commit details
-
Copy full SHA for e21cec1 - Browse repository at this point
Copy the full SHA e21cec1View commit details -
manifest: run ostree pull right before ostree deploy
Move the ostree pull stage to be right before the ostree deploy stage. This should have no functional impact on the build and will make it easier to replace the two stages together. Old vs new stage order: org.osbuild.ostree.init-fs | org.osbuild.ostree.init-fs org.osbuild.ostree.pull | org.osbuild.ostree.os-init org.osbuild.ostree.os-init | org.osbuild.mkdir org.osbuild.mkdir | org.osbuild.ostree.pull org.osbuild.ostree.deploy | org.osbuild.ostree.deploy
Configuration menu - View commit details
-
Copy full SHA for cdcc96b - Browse repository at this point
Copy the full SHA cdcc96bView commit details -
manifest: add ostree deploy stages conditionally
When creating the ostree deployment pipeline, add the appropriate stages only when the ostree commit is specified. The stages are: org.osbuild.pull org.osbuild.ostree.deploy org.osbuild.ostree.remote org.osbuild.ostree.fillvar
Configuration menu - View commit details
-
Copy full SHA for a4bd65d - Browse repository at this point
Copy the full SHA a4bd65dView commit details -
manifest: add a second constructor for ostree container deployment
Rename the NewOSTreeDeployment() constructor to NewOSTreeCommitDeployment() and add a second one called NewOSTreeContainerDeployment(). Each takes a different kind of source spec (ostree commit or container). The container constructor also requires the ref to be specified since it's not part of the container spec.
Configuration menu - View commit details
-
Copy full SHA for 9717175 - Browse repository at this point
Copy the full SHA 9717175View commit details -
manifest: add ostree.deploy.container stage to ostree deployment
Add the org.osbuild.ostree.deploy.container stage when the content source for the deployment is a container.
Configuration menu - View commit details
-
Copy full SHA for c8ea2b0 - Browse repository at this point
Copy the full SHA c8ea2b0View commit details -
image: support both commit and container sources for OSTreeDiskImage
Support both content source types on the OSTreeDiskImage ImageKind. A second constructor is defined, just like with the deployment pipeline of the image. The original constructor is renamed to NewOSTreeDiskImageFromCommit to differentiate and have a more informative name.
Configuration menu - View commit details
-
Copy full SHA for a85b7ae - Browse repository at this point
Copy the full SHA a85b7aeView commit details -
manifest: remove ignition options from OSTreeDeployment constructor
Only required properties should be specified through the constructor to make sure they are not accidentally left empty or nil. Optional properties are added via public fields of the pipeline object. Since the ignition platform is optional, change it to a public field. Also, to simplify the interaction between the two ignition properties, remove the boolean that signifies if ignition should be enabled and use the IgnitionPlatform string instead. Treat the empty string as the disabled value.
Configuration menu - View commit details
-
Copy full SHA for 404475c - Browse repository at this point
Copy the full SHA 404475cView commit details -
cmd: use internal types for config and repositories
We always aliased these types so that internal changes wouldn't always require changing our tooling interfaces but it's actually more annoying needing to change them every time something is added or changed in the internal types. These are development and testing tools. It's fine to use the internal types directly and keep them simple.
Configuration menu - View commit details
-
Copy full SHA for b43ff16 - Browse repository at this point
Copy the full SHA b43ff16View commit details -
test: update repository format
Use gpgkeys instead of concatenating multiple keys under gpgkey. The singular gpgkey was a leftover from an old format and now we use an array from the internal rpmmd.RepoConfig instead.
Configuration menu - View commit details
-
Copy full SHA for bebad6c - Browse repository at this point
Copy the full SHA bebad6cView commit details -
manifest: move root user locking into image function
Not all image types with ostree deployments will want to lock the root user account. Let's instead make it an option of the image function so that each image kind can set it itself. This change has no effect on any of the current image types / manifests.
Configuration menu - View commit details
-
Copy full SHA for a7d1c6e - Browse repository at this point
Copy the full SHA a7d1c6eView commit details -
manifest: move coreos.no_persist_ip into image functions
Not all image types that use ignition want to define the kernel option. Specifically, the (upcoming) CoreOS images wont want to enable this, so let's move it into the image function and add it when the ignition options are added. It is conditioned on the distro version for now, so we can't add it to the global image type kernel options. This change has no effect on any of the current image types / manifests.
Configuration menu - View commit details
-
Copy full SHA for 51bf424 - Browse repository at this point
Copy the full SHA 51bf424View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cca349 - Browse repository at this point
Copy the full SHA 4cca349View commit details
Commits on Nov 28, 2023
-
manifest: refactor ostree deployment stages into functions
Handle the two sets of deployment stages in two separate functions to improve readability. Co-Authored-By: Michael Vogt <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b497822 - Browse repository at this point
Copy the full SHA b497822View commit details -
We need this to get F39 CI runners but we're not switching them just yet because of a potential small issue.
Configuration menu - View commit details
-
Copy full SHA for a91eafe - Browse repository at this point
Copy the full SHA a91eafeView commit details