Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Prefetch list of targets on hover of Create blueprint button #2425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

regexowl
Copy link
Collaborator

This prefetches list of possible targets based on distribution for onMouseEnter event of Create blueprint button.

@regexowl regexowl changed the title src: Prefetch list of target on hover of Create blueprint button src: Prefetch list of targets on hover of Create blueprint button Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (1a7350e) to head (cec56c7).
Report is 2192 commits behind head on main.

Files with missing lines Patch % Lines
...Components/sharedComponents/ImageBuilderHeader.tsx 66.66% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2425      +/-   ##
==========================================
+ Coverage   75.71%   83.87%   +8.15%     
==========================================
  Files          33      157     +124     
  Lines         597    17701   +17104     
  Branches      144     1745    +1601     
==========================================
+ Hits          452    14846   +14394     
- Misses        139     2834    +2695     
- Partials        6       21      +15     
Files with missing lines Coverage Δ
...Components/sharedComponents/ImageBuilderHeader.tsx 97.54% <66.66%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5d5cf...cec56c7. Read the comment docs.

Copy link
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
its looking very good! thank you

This prefetches list of possible targets based on distribution for `onMouseEnter` event of Create blueprint button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 simple Simple and quick to review ✅ ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants