Added image-builder-frontend repository as a Cockpit package #2424
+2,326
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgold1234
force-pushed
the
first_cockpit
branch
5 times, most recently
from
d626d14
to
d020097
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2424 +/- ##
==========================================
+ Coverage 75.71% 83.18% +7.46%
==========================================
Files 33 156 +123
Lines 597 17374 +16777
Branches 144 1683 +1539
==========================================
+ Hits 452 14452 +14000
- Misses 139 2902 +2763
- Partials 6 20 +14
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
croissanne
reviewed
Sep 12, 2024
mgold1234
force-pushed
the
first_cockpit
branch
2 times, most recently
from
08ce8c7
to
fcdf7eb
Compare
|
Is this a duplicate of #2412? Can you please close a PR that is not needed anymore? |
|
@mgold1234 Yup, perfectly fine, thank you! |
mgold1234
force-pushed
the
first_cockpit
branch
from
fcdf7eb
to
b56aeef
Compare
mgold1234
force-pushed
the
first_cockpit
branch
7 times, most recently
from
4987b36
to
de18012
Compare
croissanne
requested changes
Sep 16, 2024
croissanne
reviewed
Sep 16, 2024
mgold1234
force-pushed
the
first_cockpit
branch
2 times, most recently
from
a3a6a8a
to
9e93e2d
Compare
mgold1234
force-pushed
the
first_cockpit
branch
2 times, most recently
from
ce6617b
to
ce5cdaa
Compare
mgold1234
force-pushed
the
first_cockpit
branch
7 times, most recently
from
7e5c4d2
to
889a6de
Compare
amirfefer
reviewed
Sep 22, 2024
mgold1234
force-pushed
the
first_cockpit
branch
from
c9f827c
to
62e8091
Compare
changes that allow to build and run in both onPremise (Cockpit) and Saas environments. Configured webpack with necessary loaders and plugins. `AppCockpit` file and `cockpit:build` script were added for Cockpit compatibility.
mgold1234
force-pushed
the
first_cockpit
branch
from
62e8091
to
20a23f9
Compare
We need to integrate a new API service for managing blueprints and update the Redux store to handle blueprint-related data in a Cockpit environment. This will allow us to fetch, store, and manage blueprints effectively within the application. Created a new 'cockpitApi' service to handle the API calls related to blueprints in cockpit env. Added a 'blueprintsReducer' to the Redux store to manage blueprint state. Added a new 'emptyCockpitApi' file for the blueprint API setup, including type definitions and query configurations.
- define isOnPremise boolean variable to check if its onPrem env. - define useGetFeatureFlag hook to return false in on-premise environments and dynamically call the appropriate hook (useFlag or useFlagWithEphemDefault) based on the feature flag name. Improved structure by avoiding hook calls inside conditionals to adhere to React rules
mgold1234
force-pushed
the
first_cockpit
branch
from
20a23f9
to
8201ab3
Compare
we have issue when running the cockpit:build script- the symbolic link was not created for everyone. fix it by adding a condition that check where the cockpit definition exist in the machine and create the symbolic link there.
mgold1234
force-pushed
the
first_cockpit
branch
from
8201ab3
to
b6e1d35
Compare
lucasgarfield
requested changes
Sep 23, 2024
| </Provider> | ||
| ); | ||
|
|
||
| const main = async () => { |
There was a problem hiding this comment.
This seems very similar to what we do in https://github.com/osbuild/image-builder-frontend/blob/main/src/bootstrap.tsx, could we re-use that code?
There was a problem hiding this comment.
I think that it is make sense to have entry point for each environment- one for onPrem and one for Saas.
lucasgarfield
requested changes
Sep 23, 2024
| @@ -153,6 +163,81 @@ const ImagesTable = () => { | |||
| ); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can we apply the DRY ("Don't repeat yourself") principle to lines 166 through 240? This is a lot of copy/pasted code. The goal is to not conditionally render anything and to re-use/share as much code as possible between the service and on-prem.
mgold1234
force-pushed
the
first_cockpit
branch
from
b3044aa
to
c614c65
Compare
mgold1234
force-pushed
the
first_cockpit
branch
3 times, most recently
from
2019015
to
c2e1e23
Compare
add alias to webpack config 1) api alias defines the path to onPrem cockpitAp file 2) pathRes alias define path for onPrem env 3) getFeatureFlag alias define the path to file with flags
mgold1234
force-pushed
the
first_cockpit
branch
from
c2e1e23
to
4be467d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added image-builder-frontend repository as a Cockpit package.
it will replace the cockpit-composer with image-builder-frontend for improved functionality and maintainability.