Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flow internal context into webhook context #3840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

splaunov
Copy link
Contributor

This PR adds data from `flow.internal_context' field into the context of Jsonnet mapper. So this data could be used in webhook calls.

Related issue(s)

Checklist

  • [ x] I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • [ x] I am following the
    contributing code guidelines.
  • [ x] I have read the security policy.
  • [ x] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (1a70648) to head (07b59ed).
Report is 9 commits behind head on master.

Current head 07b59ed differs from pull request most recent head 6ad618e

Please upload reports for the commit 6ad618e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3840      +/-   ##
==========================================
- Coverage   78.10%   78.01%   -0.09%     
==========================================
  Files         362      359       -3     
  Lines       25329    25191     -138     
==========================================
- Hits        19783    19653     -130     
- Misses       4028     4032       +4     
+ Partials     1518     1506      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RequestURL: x.RequestURL(req).String(),
RequestCookies: cookies(req),
Identity: session.Identity,
Flow: flow,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the internal context already available in the flow object itself? Or is it hidden in there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's part of the flow object, but it does not serialise into json:

InternalContext sqlxx.JSONRawMessage `db:"internal_context" json:"-" faker:"-"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants