Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update doc example for get oauth2-client #3773

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

anthonysterling
Copy link
Contributor

👋

This PR updates the example shown by get oauth2-client to show how to extract the client name rather than client secret, as the .client_secret property is never returned by this call which may result in some confusion.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • [] I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented May 30, 2024

CLA assistant check
All committers have signed the CLA.

@anthonysterling anthonysterling changed the title update doc example for get oauth2-client docs: update doc example for get oauth2-client May 30, 2024
@alnr alnr merged commit 5e70cde into ory:master Jun 11, 2024
28 checks passed
@alnr
Copy link
Contributor

alnr commented Jun 11, 2024

Thank you!

@anthonysterling anthonysterling deleted the anthonysterling-patch-1 branch June 21, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants