fix: do not retry sending responses #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
commented
May 8, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| if accessRequest.GetGrantTypes().ExactOne(string(fosite.GrantTypeClientCredentials)) || |
There was a problem hiding this comment.
@hperl in 67a85cc you added this transaction wrapper. The transaction handler does two things:
- Keeps the SQL connection reserved for the transaction (I think!)
- Retries the SQL statements on specific errors (like ERR_SERIALIZABLE)
Adding a lot of logic to a transaction can be very bad, because (a) it retries all the code, (b) it blocks a SQL connection.
When using a Transaction, please only wrap the code that does indeed execute SQL statements.
| } | ||
| } | ||
|
|
||
| for _, hook := range h.r.AccessRequestHooks() { | ||
| if err = hook(ctx, accessRequest); err != nil { |
There was a problem hiding this comment.
Waiting for an external system as part of a SQL transaction is an absolute no-go
| } | ||
| } | ||
|
|
||
| accessResponse, err := h.r.OAuth2Provider().NewAccessResponse(ctx, accessRequest) |
There was a problem hiding this comment.
This writes the response as often as it retries the SQL transaction.
jonas-jonas
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments