Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): add modalDesktop property #1064

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Sep 25, 2024

Fixes #1041

Proposed Changes

  • update dropdown classes
  • add prop desktopModal to Dropdown component
  • split mobileClass class and modalClass class behavior
  • refactor Drodpown component
  • remove aria-hidden from dropdown overlay

@mlmoravek mlmoravek added breaking Breaking changes feature A new feature labels Sep 25, 2024
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 939fca7
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/66f5256f88645000080f5128
😎 Deploy Preview https://deploy-preview-1064--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek merged commit 4819fb7 into develop Sep 26, 2024
10 checks passed
@mlmoravek mlmoravek deleted the feat/1041/dropdown/desktop-modal branch September 26, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: add property to force modal view
1 participant