-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use stable rustfmt #834
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
- Coverage 40.13% 39.86% -0.27%
==========================================
Files 20 20
Lines 1645 1611 -34
==========================================
- Hits 660 642 -18
+ Misses 985 969 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We should probably cut a new point release just for these changes 💀 Do you know if there is a way of keeping the git blame while changing the formatting? I'm guessing it shouldn't be possible but it would be super nice if we can keep the historic footprint on the files somehow. |
Yes, it's possible:
Should I add the |
Wow perfect, please do it 👍🏼 |
Actually, I think we need to do this in another PR, after merging this so that we know the commit to ignore 👍 |
Description
close #618
Motivation and Context
How Has This Been Tested?
Screenshots / Logs (if applicable)
Types of Changes
Checklist: