Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use stable rustfmt #834

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

MarcoIeni
Copy link
Sponsor Contributor

@MarcoIeni MarcoIeni commented Aug 31, 2024

Description

close #618

Motivation and Context

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MarcoIeni MarcoIeni marked this pull request as ready for review August 31, 2024 08:02
@MarcoIeni MarcoIeni requested a review from orhun as a code owner August 31, 2024 08:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.05006% with 958 lines in your changes missing coverage. Please review.

Project coverage is 39.86%. Comparing base (08e761c) to head (4df5a9d).

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 326 Missing ⚠️
git-cliff-core/src/changelog.rs 45.81% 168 Missing ⚠️
git-cliff-core/src/remote/mod.rs 23.08% 90 Missing ⚠️
git-cliff/src/logger.rs 0.00% 62 Missing ⚠️
git-cliff-core/src/repo.rs 70.52% 46 Missing ⚠️
git-cliff-core/src/remote/bitbucket.rs 0.00% 43 Missing ⚠️
git-cliff-core/src/remote/gitlab.rs 34.10% 29 Missing ⚠️
git-cliff-core/src/remote/gitea.rs 32.44% 25 Missing ⚠️
git-cliff-core/src/remote/github.rs 32.44% 25 Missing ⚠️
git-cliff-core/src/config.rs 56.61% 23 Missing ⚠️
... and 10 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   40.13%   39.86%   -0.27%     
==========================================
  Files          20       20              
  Lines        1645     1611      -34     
==========================================
- Hits          660      642      -18     
+ Misses        985      969      -16     
Flag Coverage Δ
unit-tests 39.86% <40.06%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented Aug 31, 2024

We should probably cut a new point release just for these changes 💀

Do you know if there is a way of keeping the git blame while changing the formatting? I'm guessing it shouldn't be possible but it would be super nice if we can keep the historic footprint on the files somehow.

@MarcoIeni
Copy link
Sponsor Contributor Author

@orhun
Copy link
Owner

orhun commented Sep 1, 2024

Wow perfect, please do it 👍🏼

@MarcoIeni
Copy link
Sponsor Contributor Author

Actually, I think we need to do this in another PR, after merging this so that we know the commit to ignore 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use stable rust for cargo-fmt
3 participants