Update isMouseDown = false on double click. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the `splitpanes--dragging` class disappear after splitter double click. This results in a correct folding/expanding transition on double click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
splitpanes--draggingclass disappear after splitter double click.This results in a correct folding/expanding transition on double click. Before this PR, if you double click on a splitter you'd see the pane gets expanded, but without animation.
It was kinda half my fault in my old PR #5, but it's half of the original code fault, because on double click
isMouseDownistrue, at least in Firefox, while it definitely should befalse.I think the reasoning is because on the second click of the double click, the browser doesn't sends the event of
mouseUp, but rather sends the event ofdblClick.