Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service date from cache key of SiriTripPatternCache #6069

Open
wants to merge 2 commits into
base: dev-2.x
Choose a base branch
from

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Sep 17, 2024

Summary

In today's real time meeting we talked about the indexing of trip patterns in the SiriTripPatternCache and we came to the following conclusion:

  • we don't really know why the cache key contains the service date
  • even though we are uneasy about it, @vpaturet agreed to just try it out on Entur's staging system to find out if there are negative consequences

Issue

#4002

@leonardehrenfried leonardehrenfried added the RealTimeUpdate The issue/PR is related to RealTime updates label Sep 17, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner September 17, 2024 13:08
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.79%. Comparing base (e9200c0) to head (f8d76b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6069   +/-   ##
==========================================
  Coverage      69.79%   69.79%           
  Complexity     17358    17358           
==========================================
  Files           1962     1962           
  Lines          74357    74346   -11     
  Branches        7623     7621    -2     
==========================================
- Hits           51894    51887    -7     
+ Misses         19819    19816    -3     
+ Partials        2644     2643    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t2gran t2gran added this to the 2.7 (next release) milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RealTimeUpdate The issue/PR is related to RealTime updates Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants