Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make operation_name configurable #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

el-stano
Copy link

@el-stano el-stano commented Oct 9, 2020

Hello, could we make operation_name configurable?

@mpetazzoni
Copy link
Collaborator

I'm not sure this would help much, as most code rarely uses Session.request() directly; it is instead called by other methods like .get(...) or .post(...).

@el-stano
Copy link
Author

I thought one could still use e.g. session.post(some_url, data=some_data, operation_name="entity.create") -- since .get(...) and .post(...) essentially hand their kwargs over to .request(...)?

https://github.com/psf/requests/blob/master/requests/sessions.py#L590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants