Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example project: Require django<2 #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Example project: Require django<2 #57

wants to merge 2 commits into from

Conversation

bj00rn
Copy link

@bj00rn bj00rn commented Jun 25, 2019 •
edited
Loading

Example project fails to run with django2 due to changes

  • add requirements.txt in example project
  • require django<2 due to middleware changes in django 2.0
  • note to install dependencies in READ.me

Alernate course of action would be to migrate example project to django2

Jamim
Jamim reviewed Jun 25, 2019
View reviewed changes
example/requirements.txt
@@ -0,0 +1,2 @@
Django<2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of this PR is Example project: Require django>2, but here I see Django<2 🤔

Copy link
Author

@bj00rn bj00rn Jun 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed typos in title and commits 😭.

need to get my 🐊s straight

@bj00rn bj00rn changed the title Example project: Require django>2 Example project: Require django<2 Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamim Jamim Jamim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bj00rn @Jamim