Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncp] integrate Netif TX/RX with Ncp #2467

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR integrates the Netif TX/RX functionality with NCP spinel.

This PR enables bidirectional IP packet exchange between the wpan interface and NCP. This PR adds a ping test to verify the connectivity.

The PR depends on #2452.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 45.49%. Comparing base (2b41187) to head (276dbde).
Report is 791 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/ncp_spinel.cpp 0.00% 19 Missing ⚠️
src/ncp/ncp_host.cpp 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2467       +/-   ##
===========================================
- Coverage   55.77%   45.49%   -10.29%     
===========================================
  Files          87       99       +12     
  Lines        6890    11686     +4796     
  Branches        0      849      +849     
===========================================
+ Hits         3843     5316     +1473     
- Misses       3047     6093     +3046     
- Partials        0      277      +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@Irving-cl Irving-cl requested a review from jwhui September 6, 2024 00:55
@jwhui jwhui changed the title [NCP] Integrate Netif TX/RX with Ncp [ncp] integrate Netif TX/RX with Ncp Sep 6, 2024
@jwhui jwhui merged commit 79d6104 into openthread:main Sep 6, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants