[callback] update OnceCallback to clear moved-from rvalue reference
#1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abtink
force-pushed
the
callback/fix-once-callback
branch
from
83e2b98
to
cd7af36
Compare
This commit updates the `OnceCallback` move constructor and move assignment operator to ensure that the passed-in rvalue reference is cleared.
abtink
force-pushed
the
callback/fix-once-callback
branch
from
cd7af36
to
436046f
Compare
jwhui
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
OnceCallbackmove constructor and move assignment operator to ensure that the passed-in rvalue reference is cleared.Should help address #1912.