Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus on main when content changes #2221

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Focus on main when content changes #2221

wants to merge 8 commits into from

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Apr 12, 2024 •
edited by jira bot
Loading

@RoyEJohnson RoyEJohnson requested a review from a team as a code owner April 12, 2024 14:51
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-chctpn April 12, 2024 14:51 Inactive
@sentry-io Sentry.io
Copy link

sentry-io bot commented Apr 12, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/app/content/components/Page/scrollToTopOrHashManager.ts

Function Unhandled Issue
scrollToTop TypeError: Cannot read properties of null (reading 'tabIndex') resetTabIndex(rex/releases/v4/aff2e9c/static...
Event Count: 1 Affected Users: 4

Did you find this useful? React with a 👍 or 👎

Dantemss
Dantemss approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like in principle it should work

src/app/components/MainContent.tsx Outdated Show resolved Hide resolved
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-chctpn April 16, 2024 19:17 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-chctpn April 19, 2024 17:29 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-chctpn April 22, 2024 16:22 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-chctpn April 23, 2024 14:51 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-chctpn April 23, 2024 16:40 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-focus-on-main-w-6dwn7k April 30, 2024 19:13 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 1, 2024 19:01 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 2, 2024 19:35 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 2, 2024 20:51 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 2, 2024 21:31 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 3, 2024 14:32 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 3, 2024 14:33 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 6, 2024 18:57 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 6, 2024 21:44 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-6dwn7k May 7, 2024 20:34 Inactive
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from 4881908 to a052faa Compare May 14, 2024 20:11
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch 2 times, most recently from 0c53803 to a6f8511 Compare June 5, 2024 15:01
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-focus-on-main-w-ygl64e June 26, 2024 16:08 Inactive
@Malar-Natarajan
Copy link
Contributor

@RoyEJohnson The CI check Test is failing. Could you please have a look.

@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ygl64e June 26, 2024 19:27 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ygl64e June 27, 2024 17:01 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ygl64e June 27, 2024 17:24 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ygl64e June 27, 2024 17:52 Inactive
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from 33cdd33 to da7eaad Compare June 28, 2024 12:12
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 8, 2024 18:23 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 8, 2024 18:24 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 9, 2024 18:05 Inactive
@Malar-Natarajan
Copy link
Contributor

@RoyEJohnson could you please resolve conflicts in this PR

@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from 6b523b5 to 8235391 Compare August 12, 2024 21:16
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 12, 2024 21:16 Inactive
@RoyEJohnson
Copy link
Contributor Author

@Malar-Natarajan Resolved.

@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 13, 2024 17:16 Inactive
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from b4b34fb to 744d8ee Compare August 13, 2024 18:57
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 13, 2024 18:57 Inactive
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from 744d8ee to 9dd04f7 Compare August 13, 2024 19:32
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 13, 2024 19:32 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 13, 2024 23:18 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 15, 2024 16:13 Inactive
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from 6682db0 to c7a4f21 Compare August 15, 2024 16:27
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 15, 2024 16:27 Inactive
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from c7a4f21 to 63efc5a Compare August 15, 2024 16:29
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 15, 2024 16:29 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-focus-on-main-w-ouqehe August 16, 2024 14:29 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-focus-on-main-w-xt2s53 August 22, 2024 21:22 Inactive
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from 6b19b0b to b3ad020 Compare September 17, 2024 14:27
@RoyEJohnson RoyEJohnson force-pushed the focus-on-main-when-content-updates branch from 9bd29e2 to f67c1fd Compare September 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWoodward TomWoodward TomWoodward approved these changes

@Dantemss Dantemss Dantemss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RoyEJohnson @Malar-Natarajan @TomWoodward @Dantemss