add some more block types #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwvolo
approved these changes
Jul 25, 2024
| @@ -105,6 +109,11 @@ class RootPage(Page): | |||
| ('image', APIImageChooserBlock(required=False)), | |||
| ('image_alt', blocks.CharBlock(required=False)), | |||
| ('config', blocks.StreamBlock([ | |||
| ('id', blocks.RegexBlock( | |||
There was a problem hiding this comment.
are the options for this going to be documented somewhere?
how do you expect this will be used?
There was a problem hiding this comment.
the id is the HTML id, which can be used in anchor links to link to a part of the page
i should probably go through and add some more useful help text to all the options. i was also gonna make some persistent pages on dev to showcase the different content types
mwvolo
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds