Improved mobile and tablet exp #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coder-Srinivas
commented
Sep 10, 2024
•
Coder-Srinivas
commented
- Improved the responsiveness of study cards and studies page
- Made the study banner and currated studies responsive
- Improved the responsiveness of Achievements page
- Added a loading overlay
chrisbendel
reviewed
Sep 16, 2024
| @@ -179,7 +179,7 @@ const Achievements:FC = () => { | |||
| return ( | |||
| <Box> | |||
| <TopNavBar /> | |||
| <Container size="lg" my="xl"> | |||
| { Object.keys(learningPaths).length > 0 ? <><Container size="lg" my="xl"> | |||
There was a problem hiding this comment.
this can prob be cleaned up up above ie something like...
if (!Object.keys(learningPaths).length) {
return <LoadingAnimation />
}
chrisbendel
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.