Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bundles include all the Required Infrastructure Annotations #220

Merged

Conversation

mrkisaolamb
Copy link
Contributor

Implements: OSPRH-7936

@mrkisaolamb mrkisaolamb requested review from gibizer and SeanMooney and removed request for abays and frenzyfriday June 25, 2024 08:12
Copy link
Collaborator

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot comment on the TLS flag. I think we need somebody from security to make a decision. I don't know what are the "well known" tunables, and and also the "any workloads it manages" is a very blanket statement.

operatorframework.io/suggested-namespace: openstack
operators.openshift.io/infrastructure-features: '["disconnected"]'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this is superceeded by features.operators.openshift.io/disconnected: "true"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -6,8 +6,12 @@ metadata:
capabilities: Basic Install
features.operators.openshift.io/disconnected: "true"
features.operators.openshift.io/fips-compliant: "true"
features.operators.openshift.io/proxy-aware: "false"
features.operators.openshift.io/tls-profiles: "true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one we were a littel unsure about.
the only tls endpoint the operator has is the webhook.

if this is referring to the deployment of placement then in theory you can use the service override to tweak the tls profile of the relevant openshfit route that is used to expose it so in that context it would be true.

did we get clarity on if that counted in this context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a now there is no clarity with tls so I put this pr on hold

Comment on lines +9 to +13
features.operators.openshift.io/proxy-aware: "false"
features.operators.openshift.io/tls-profiles: "false"
features.operators.openshift.io/token-auth-aws: "false"
features.operators.openshift.io/token-auth-azure: "false"
features.operators.openshift.io/token-auth-gcp: "false"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is aligned with what we agreed on the today's podified call.

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gibizer,mrkisaolamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0b9bd13 into openstack-k8s-operators:main Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants