Add amphora image tag configuration #383
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weinimo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This configures the cloud to use the amphora image with vertical scaling optimization when using a compute flavor with multiple vCPUs. JIRA: https://issues.redhat.com/browse/OSPRH-8446
weinimo
force-pushed
the
amphora-image-tag
branch
from
8932b8f
to
27b7674
Compare
pkg/amphoracontrollers/flavors.go
Outdated
| @@ -230,7 +238,7 @@ func ensureFlavors(osclient *openstack.OpenStack, log *logr.Logger, instance *oc | |||
| log.Info(fmt.Sprintf("Creating Octavia flavor profile \"%s\"", flavorProfileCreateOpts.Name)) | |||
| fp, err := flavorprofiles.Create(lbClient, flavorProfileCreateOpts).Extract() | |||
| if err != nil { | |||
| return "", err | |||
| return "", fmt.Errorf("error creating flavor profiles: %w", err) | |||
There was a problem hiding this comment.
I think we need to have a fallback when a flavorprofile cannot be created (for instance if the image tag doesn't exist).
we could ignore the error and continue, or maybe report an error only if none of the flavors were created successfully.
Right now, this patch will block the promotion pipeline with upstream content
There was a problem hiding this comment.
Thanks for the suggestion. I've pushed an update that should implement that idea.
Return error only if none of the flavors could be configured.
weinimo
force-pushed
the
amphora-image-tag
branch
from
529f783
to
c3b4d38
Compare
This configures the cloud to use the amphora
image with vertical scaling optimization when
using a compute flavor with multiple vCPUs.
https://issues.redhat.com/browse/OSPRH-8446