use DeleteDatabaseAndAccountFinalizers

[zzzeek]

This switches the use of GetDatabaseAndAccount +
database.DeleteFinalizers() to use a new function in mariadb DeleteDatabaseAndAccountFinalizers, which looks up each individual component used for database access individually and removes finalizers from all of those that were found, regardless of other elements not
existing. All controllers should be changed to use this method to
ensure that early-created MariaDBAccount objects are removed from a
control plane where MariaDBDatabase objects did not get created before
the control plane were deleted, as well as similar scenarios.

relies upon openstack-k8s-operators/mariadb-operator#268

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zzzeek
Once this PR has been reviewed and has the lgtm label, please assign mrkisaolamb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/355719ef7f73466189f1f535b5b9c1e6

✔️ openstack-meta-content-provider SUCCESS in 2h 51m 15s
✔️ nova-operator-kuttl SUCCESS in 39m 08s
❌ nova-operator-tempest-multinode FAILURE in 1h 16m 37s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 23m 18s

[zzzeek]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4594b1e8fd484d02aa6bb428df5ccad7

✔️ openstack-meta-content-provider SUCCESS in 1h 43m 06s
✔️ nova-operator-kuttl SUCCESS in 41m 26s
❌ nova-operator-tempest-multinode FAILURE in 1h 16m 07s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 26m 39s

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[auniyal61]

this is a [DNM] patch. as its targeting a unmerged patch/build

because the depends-on mariadb patch did not merged yet here

okay its defined here

though DeleteDatabaseAndAccountFinalizers additionaly delete "unused" MariaDBAccounts, which seems like something do be done on restart/start, instead of individual req.
while DeleteFinalizer only for asked account.
but that is a part of mariadb-operator..

the change seems to be working fine here. but it is a [DNM] patch.

[zzzeek]

though DeleteDatabaseAndAccountFinalizers additionaly delete "unused" MariaDBAccounts, which seems like something do be done on restart/start, instead of individual req. while DeleteFinalizer only for asked account. but that is a part of mariadb-operator..

this is not new functionality in the mariadb operator, it was there previously, and it's to delete any other MariaDBAccounts that may have existed previously regarding the particular MariaDBDatabase that the nova operator here wants to ensure is gone. when an account rotation occurs, a new MariaDBAccount is created, and finalizers will be removed from the old MariaDBAccount, however it does not automatically delete the old MariaDBAccount. this is not any kind of change right now.