bump to golang 1.21 #470
Merged
bump to golang 1.21 #470
+97
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuggi
force-pushed
the
golang_1.21
branch
7 times, most recently
from
ed9f4a5
to
474d1d1
Compare
bshephar
reviewed
Sep 17, 2024
| sigs.k8s.io/controller-runtime v0.16.6 | ||
| k8s.io/api v0.29.2 | ||
| k8s.io/apimachinery v0.29.2 | ||
| sigs.k8s.io/controller-runtime v0.17.5 |
There was a problem hiding this comment.
Do we want to do latest 0.17.x everywhere:
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.6
There was a problem hiding this comment.
I wanted to have something to verify that renovate to bump things properly
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v1.59.1 (1.60 >= golang 1.22; 1.61 >= golang 1.23)
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.21-sdk-1.31
Jira: OSPRH-6501
Signed-off-by: Martin Schuppert <[email protected]>
Signed-off-by: Martin Schuppert <[email protected]>
* Bump k8s api, apimachinery, client-go to 0.29 * bump controller-runtime to 0.17 * change github.com/openshift/api to match latest commit for release-4.16 branch * update ENVTEST_K8S_VERSION to 1.29 match with k8s version
When the golang version does not match the version used inside the build container, dowloading the modules can fail with: ~~~ go: go.work requires go >= 1.21.13 (running go 1.21.11; GOTOOLCHAIN=local) ~~~ This PR makes set the GOTOOLCHAIN to set 1.21.0 as the min required version and sets it in go.work file. Signed-off-by: Martin Schuppert <[email protected]>
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olliewalsh, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7c76cf1
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com//browse/OSPRH-6501