Proposed PR455 #464
Closed
Proposed PR455 #464
+177
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently only creating the `clouds.yaml` and `secure.yaml` for the openstack client and not the classic `cloudrc` file that was usually sourced for individual clients. This makes sense if there were parity between the openstck client and all the individual clients, but there are still missing features. For example: - The `openstack volume service list` cannot show the cluster. - The `openstack volume service list` cannot show the backend state. - There is no support for any of the default volume type commands: set, show, list, unset. These are some of the ones we know about, but there could be more. Users will need to use the old `cinder` client, so we should make it convenient for them by having the `cloudrc` available in the `openstackclient` pod. This patch adds the `cloudrc` key in the `openstack-config-secret` secret to make it possible for the `openstack-operator` to mount it in the `openstackclient` pod.
We also took the opportunity and added patch to all the existing rbac rules that had update already to avoid similar issues in the future Resolves: https://issues.redhat.com/browse/OSPRH-8363 Signed-off-by: Martin Schuppert <[email protected]>
Adding patch rbac perm for serviceaccounts
…rators/renovate/openstack-k8s-operators fix(deps): update openstack-k8s-operators
Related: [OSPRH-8218](https://issues.redhat.com//browse/OSPRH-8218) Signed-off-by: Martin Schuppert <[email protected]>
Remove Icon from bundle
…rators/renovate/openstack-k8s-operators fix(deps): update openstack-k8s-operators
…rators/renovate/k8s.io fix(deps): update k8s.io/utils digest to 18e509b
…rators/renovate/github.com-gophercloud-gophercloud-1.x fix(deps): update module github.com/gophercloud/gophercloud to v1.13.0
…rators/cloudcr Create cloudrc contents in openstack-config-secret
…rators/renovate/openstack-k8s-operators fix(deps): update openstack-k8s-operators
…rators/renovate/k8s.io fix(deps): update k8s.io to v0.28.12
…rators/renovate/openstack-k8s-operators fix(deps): update openstack-k8s-operators
…rators/renovate/openstack-k8s-operators fix(deps): update openstack-k8s-operators to 431d0dc
instance.Status.Conditions.MarkTrue() always sets the current time as the LastTransitionTime and this results in infinite loop as the LastTransitionTime changes after every reconcile. I think this issue is there in many other operator controllers, but we don't see the issue as the next reconcile is probably too quick to not change the LastTransitionTime(precision for which is in seconds). The issue showed up in dataplane controllers as we reconcile a number of services in a loop for every reconcile of nodeset. Jira: OSPRH-8811 Signed-off-by: rabi <[email protected]>
Restore LastTransitionTime after setting Ready Condition
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
…rators/renovate/openstack-k8s-operators fix(deps): update openstack-k8s-operators
…rators/renovate/openstack-k8s-operators fix(deps): update openstack-k8s-operators
…rators/renovate/gomega fix(deps): update module github.com/onsi/gomega to v1.34.1
…rators/renovate/ginkgo fix(deps): update module github.com/onsi/ginkgo/v2 to v2.19.1
Currently the reconciler returned both a non-zero result and a non-nil error. The result will always be ignored if the error is non-nil and the non-nil error causes reqeueuing with exponential backoff. In case of NotFound return nil that the ReqeueAfter is used. For more details, see: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/reconcile#Reconciler Signed-off-by: Martin Schuppert <[email protected]>
…eAfter Return nil error in case NotFound and to use RequeueAfter
…x_osp_secret Update reconcileNormal to use VerifySecret
…rators/renovate/openstack-k8s-operators fix(deps): update openstack-k8s-operators
…rators/renovate/ginkgo fix(deps): update module github.com/onsi/ginkgo/v2 to v2.20.0
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mauricioharley The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
It looks like the rebase didn't work properly, given all the extra commits added to the PR |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Handled in #466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR just for the sake of having the original PR's changes pushed to the 18.0.0-proposed branch.