update mariadb to include finalizer secret logic #393
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this PR updates mariadb-operator to include [1], which will add / remove finalizers on the Secret objects that are associated with MariaDBAccount objects. This ensures that GetDatabaseByNameAndAccount will successfully locate a MariaDBDatabase/MariaDBAccount/Secret trio, rather than returning not found, allowing ``Database.DeleteFinalizer()`` to be called when a resource is in reconcile delete. [1] openstack-k8s-operators/mariadb-operator#210
|
New changes are detected. LGTM label has been removed. |
|
keystone is still behind, this needs to merge |
|
@zzzeek Looks like KUTTL tests need to be updated: |
|
yup |
|
that failure is a little bit odd. i will add that finalizer and see if it helps. but...might need to understand what's going on there |
|
i think that finalizer is not supposed to be there. let me do a retest and if that fails ill try to run it all locally |
|
/retest |
openshift-merge-bot
bot
merged commit e5f8627
into
openstack-k8s-operators:main
|
Ok I guess the previous fail was a timeout situation |
this PR updates mariadb-operator to include [1], which will add / remove finalizers on the Secret objects that are associated with MariaDBAccount objects. This ensures that GetDatabaseByNameAndAccount will successfully locate a MariaDBDatabase/MariaDBAccount/Secret trio, rather than returning not found, allowing
Database.DeleteFinalizer()to be called when a resource is in reconcile delete.[1] openstack-k8s-operators/mariadb-operator#210