Ensure KeystoneAPI is ready in kuttl tests

[kajinamit]

This ensures the Ready condition of KeystoneAPI becomes ready in every deployment step. Note that the condition should be false in case no pod is available so it is intentionally asserted to be false in case keystone service is scaled down to 0.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kajinamit
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abays]

/test keystone-operator-build-deploy-kuttl

[abays]

/test keystone-operator-build-deploy-kuttl

[openshift-ci]

@kajinamit: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/keystone-operator-build-deploy-kuttl	e5e7743	link	false	/test keystone-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[abays]

This won't work with KUTTL because it requires YAML lists to be in an exact order and have the exact number of items:

case.go:231: resource KeystoneAPI:keystone-kuttl-tests/keystone: .status.conditions: slice length mismatch: 1 != 13

[kajinamit]

Hmm. OK so we need to query a specific key instead. I'll postpone this now but will look into any better solutions when I get time.

[abays]

One way to do this is to check for the associated KeystoneAPI service pod that has this label and this status:

metadata:
...
  labels:
    service: keystone
...
status:
  ...
  phase: Running
  ...

Or we could update the Deployment created for the KeystoneAPI to give it that label as well (it currently lacks it), and then check its Status.ReadyReplicas.