Make ceph device persistent #773
Conversation
bogdando
requested review from
jistr and
fultonj
and removed request for
fao89 and
karelyatin
bogdando
force-pushed
the
fix_persist_ceph
branch
from
247a8b3
to
9dfda88
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bogdando, fao89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e0d81657cbbb4bb58bb401a70ffd2cb1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 07s |
|
recheck rdoproject.org/github-check no logs |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cfab01e44e094bf894303b55d0bf4181 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 05s |
|
recheck rdoproject.org/github-check no logs |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/962de64242fb4cb49414dadddd259a2d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 15s |
Persist /dev/vg2/data-lv2 as a systemd service to align ceph deployment with that ci-framework does for Ceph deployment on standalone tripleo. Add standalone_revert.sh script to ensure the time is synchronized and /dev/vg2/data-lv2 device is recreated, after restoring VM from the clean snapshot. Add env vars to allow ssh commands functional after revert is done (for Makefile targets standalone_deploy and standalone_revert). Signed-off-by: Bohdan Dobrelia <[email protected]>
bogdando
force-pushed
the
fix_persist_ceph
branch
from
9dfda88
to
1e5a03f
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/366fb829535a4b09908840fe0f7ac8f3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 15s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b48e21eadf2d437ba33b404f0e24709c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 17s |
| cat /tmp/ceph-osd-losetup.service | sudo tee /etc/systemd/system/ceph-osd-losetup.service | ||
| sudo chmod 0644 /etc/systemd/system/ceph-osd-losetup.service | ||
| sudo systemctl daemon-reload | ||
| sudo systemctl enable --now ceph-osd-losetup.service |
There was a problem hiding this comment.
Why is this needed? In my env i can snapshot-restore using the make targets and the loopback device is still present. Are you snapshotting some other way?
There was a problem hiding this comment.
testing shows that ensuring the unit is started after reboot is sufficient (and having it stopped results in missing loop device). Reverting doesn't cause problems here. So I will rework this
| SSH_OPT="-o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -i $SSH_KEY_FILE" | ||
|
|
||
| virsh snapshot-revert --domain edpm-compute-${EDPM_COMPUTE_SUFFIX} --snapshotname clean | ||
| ssh $SSH_OPT root@$IP systemctl stop chronyd ';' chronyd -q \'pool pool.ntp.org iburst\' ';' systemctl start chronyd |
There was a problem hiding this comment.
+1 on setting the clock, which doesn't seem to be done automatically after reverting from the snapshot.
But why the manual setting with pool.ntp.org? That will get blocked inside our network. For me just systemctl restart chronyd seems to bring the clock up to date (and it's using the configured NTP server).
There was a problem hiding this comment.
good point. I think we can split this off into a different patch
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Persist /dev/vg2/data-lv2 as a systemd service to align ceph deployment with that ci-framework does for Ceph deployment on standalone tripleo.
Add standalone_revert.sh script to ensure the time is synchronized and /dev/vg2/data-lv2 device is recreated, after restoring VM from the clean snapshot.
Add env vars to allow ssh commands functional after revert is done (for Makefile targets standalone_deploy and standalone_revert).