Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add barbican commands to makefile #258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jparoly
Copy link
Contributor

@jparoly jparoly commented May 10, 2023

Change-Id: Ie032ab5201c5fe08d86c9cb2077d97a5d13449b9

Depends-on: openstack-k8s-operators/barbican-operator#5

kubectl-kuttl test --config ${BARBICAN_KUTTL_CONF} ${BARBICAN_KUTTL_DIR}

.PHONY: barbican_kuttl
barbican_kuttl: namespace input openstack_crds openstack_storage_crds deploy_cleanup mariadb mariadb_deploy keystone keystone_deploy barbican_deploy_prep barbican ## runs kuttl tests for the barbican operator. Installs openstack and openstack-storage crds, mariadb, keystone and barbican operators and cleans up previous deployments before running the tests and, add cleanup after running the tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from the controller files from barbican-operator, the only dependency that will be need is infra, but will need later confirmation as it seems the operator it's in a very early stage (there are no images pushed to quay yet).

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jparoly
Once this PR has been reviewed and has the lgtm label, please assign sandeepyadav93 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays
Copy link
Contributor

abays commented May 16, 2023

recheck

@jparoly
Copy link
Contributor Author

jparoly commented May 16, 2023

/retest

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@abays
Copy link
Contributor

abays commented May 19, 2023

Until Barbican is added to the OpenStack operator bundle, this can fail in a fresh environment because the make deploy_cleanup will not have the Barbican CRDs available in the OCP cluster (CRDs that are installed via make openstack_crds, which reads from the OpenStack operator bundle). Just a heads-up.

@abays
Copy link
Contributor

abays commented May 19, 2023

When I try make barbican_kuttl with this patch, I get the following errors during the KUTTL tests:

    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | The Barbican "barbican-sample" is invalid: 
    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | * spec.barbicanAPI.externalEndpoints[0].endpoint: Required value
    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | * spec.serviceAccount: Required value

@cescgina
Copy link
Contributor

When I try make barbican_kuttl with this patch, I get the following errors during the KUTTL tests:

    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | The Barbican "barbican-sample" is invalid: 
    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | * spec.barbicanAPI.externalEndpoints[0].endpoint: Required value
    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | * spec.serviceAccount: Required value

I got the same error while trying make barbican_deploy looks like the sample from https://github.com/openstack-k8s-operators/barbican-operator/blob/main/config/samples/barbican_v1beta1_barbican.yaml is missing two required fields.

endpoint in https://github.com/openstack-k8s-operators/barbican-operator/blob/2ca654c53f1784d070761b01e9cee72473dfc362/config/samples/barbican_v1beta1_barbican.yaml#L48 should be set to some value and the spec should have a serviceAccount

Change-Id: Ie032ab5201c5fe08d86c9cb2077d97a5d13449b9
@jparoly
Copy link
Contributor Author

jparoly commented May 19, 2023

When I try make barbican_kuttl with this patch, I get the following errors during the KUTTL tests:

    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | The Barbican "barbican-sample" is invalid: 
    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | * spec.barbicanAPI.externalEndpoints[0].endpoint: Required value
    logger.go:42: 14:55:12 | basic-deployment/1-deploy-barbican | * spec.serviceAccount: Required value

I got the same error while trying make barbican_deploy looks like the sample from https://github.com/openstack-k8s-operators/barbican-operator/blob/main/config/samples/barbican_v1beta1_barbican.yaml is missing two required fields.

endpoint in https://github.com/openstack-k8s-operators/barbican-operator/blob/2ca654c53f1784d070761b01e9cee72473dfc362/config/samples/barbican_v1beta1_barbican.yaml#L48 should be set to some value and the spec should have a serviceAccount

operator is still being developed it seems, so this is blocked by: https://issues.redhat.com/browse/OSP-22827

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@jparoly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/install-yamls-deploy 2a3dd2f link false /test install-yamls-deploy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmendiza
Copy link
Contributor

This PR can be closed now that #577 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants