-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disk_format kuttl tests #518
base: main
Are you sure you want to change the base?
Add disk_format kuttl tests #518
Conversation
This patch introduces kuttl tests to check the resources that are supposed to be generated when the disk_format is defined.
Hi @maximsava12. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This should be rebased at least on top of #520, so we'll test it once the dependencies are in place. |
This patch introduces kuttl tests to check the resources that are supposed to be generated when the disk_format is defined.
This patch introduces kuttl tests to check the resources that are supposed to be generated when the disk_format is defined.
This patch introduces kuttl tests to check the resources that are supposed to be generated when the disk_format is defined.
This patch introduces kuttl tests to check the resources that are supposed to be generated when the disk_format is defined.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maximsava12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made another pass and I think we're going to the right path. It will be something we can test and merge after a few minor changes
kind: TestStep | ||
commands: | ||
- script: | | ||
oc kustomize ../../../../config/samples/layout/single | oc apply -n $NAMESPACE -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line (L5), and instead change config/samples/disk_format/disk_format.yaml
to be like the following:
# Inject inject_metadata config
apiVersion: glance.openstack.org/v1beta1
kind: Glance
metadata:
name: glance
spec:
serviceUser: glance
databaseInstance: openstack
databaseAccount: glance
keystoneEndpoint: default
customServiceConfig: |
[image_format]
disk_formats=raw,iso
glanceAPIs:
default:
type: single
replicas: 1
This way you can directly deploy what you need with a single command.
Also, given this layout covers a kuttl test, can we move disk_format
under layout
folder?
kind: TestStep | ||
commands: | ||
- script: | | ||
oc kustomize ../../../../config/samples/layout/single | oc delete -n $NAMESPACE -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L5 here can be changed to be:
oc kustomize ../../../../config/samples/layout/disk_format | oc delete -n $NAMESPACE -f -
after you move everything under layout
directory.
kind: TestStep | ||
commands: | ||
- command: | | ||
oc -n $NAMESPACE exec -it openstackclient --stdin=false -- /bin/sh -c "DOMAIN=glance-default-single.$NAMESPACE.svc ./scripts/create-image.sh raw" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the script I think you don't need "DOMAIN=glance-default-single.$NAMESPACE.svc
.
Remove it from L5 and L7.
This patch introduces kuttl tests to check the resources that are supposed to be generated when the disk_format is defined.
This patch introduces kuttl tests to check the resources that are supposed to be generated when the disk_format is defined.
/ok-to-test |
@maximsava12: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This patch introduces kuttl tests to check the resources that are supposed to be generated when the disk_format is defined.