Introduce envTest for glanceapi_controller #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
force-pushed
the
glanceapi_crtl_envtest
branch
2 times, most recently
from
a7833a2
to
0191e2b
Compare
This patch introduces envTests for glanceapi_controller, and improves the way the top-level glance_controller is tested. Signed-off-by: Francesco Pantano <[email protected]>
fmount
force-pushed
the
glanceapi_crtl_envtest
branch
from
0191e2b
to
f84d84c
Compare
|
/retest-required |
|
/test functional |
|
/test glance-operator-build-deploy-kuttl |
|
/test functional |
1 similar comment
|
/test functional |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, konan-abhi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 8e004d7
into
openstack-k8s-operators:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces envTest(s) for
glanceapi_controller, and improves the way the top-level glance_controller is tested.