Merge pull request #761 from rabi/refine_facts

Refine ansible_facts collection

molecule/common/test_deps/tasks/main.yml

@@ -16,7 +16,10 @@
 
 - name: Gather facts if they don't exist
   ansible.builtin.setup:
-    gather_subset: min
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "distribution"
   when: "'distribution' not in ansible_facts"
   tags:
     - always

roles/edpm_bootstrap/tasks/packages.yml

@@ -16,11 +16,15 @@
 
 - name: Gather facts if they don't exist
   ansible.builtin.setup:
-    gather_subset: min
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "distribution"
   when: "'distribution' not in ansible_facts"
   tags:
     - always
 
+
 # Currently only supported on RHEL as edpm does not have a version package
 
 - name: Install release version package

roles/edpm_frr/tasks/configure.yml

@@ -39,8 +39,12 @@
           Please check value of Ansible variable edpm_frr_bgp_uplinks.
 
 - name: Gather facts if they don't exist
+  when: "'system' not in ansible_facts"
   ansible.builtin.setup:
-    gather_subset: min
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "system"
 
 - name: Configure FRR
   ansible.builtin.template:

roles/edpm_frr/tasks/install.yml

@@ -38,7 +38,7 @@
 
 - name: Gather SELinux fact if needed
   when:
-    - ansible_facts.selinux is undefined
+    - "'selinux' not in ansible_facts"
   ansible.builtin.setup:
     gather_subset:
       - "!all"

roles/edpm_logrotate_crond/tasks/install.yml

@@ -27,7 +27,7 @@
 
 - name: Gather SELinux fact if needed
   when:
-    - ansible_facts.selinux is undefined
+    - "'selinux' not in ansible_facts"
   ansible.builtin.setup:
     gather_subset:
       - "!all"

roles/edpm_network_config/tasks/network_config.yml

@@ -16,7 +16,7 @@
 
 - name: Gather SELinux fact if needed
   when:
-    - ansible_facts.selinux is undefined
+    - "'selinux' not in ansible_facts"
   ansible.builtin.setup:
     gather_subset:
       - "!all"

roles/edpm_neutron_metadata/tasks/install.yml

@@ -32,7 +32,7 @@
 
 - name: Gather SELinux fact if needed
   when:
-    - ansible_facts.selinux is undefined
+    - "'selinux' not in ansible_facts"
   ansible.builtin.setup:
     gather_subset:
       - "!all"

roles/edpm_neutron_ovn/tasks/configure.yml

@@ -27,8 +27,12 @@
       when: cacert_bundle_exists.stat.exists
 
 - name: Gather facts if they don't exist
+  when: "'system' not in ansible_facts"
   ansible.builtin.setup:
-    gather_subset: min
+    gather_subset:
+      - "!all"
+      - "!min"
+      - "system"
 
 - name: Configure neutron configuration files
   block:

roles/edpm_nodes_validation/tasks/main.yml

@@ -15,6 +15,7 @@
 # under the License.
 
 - name: Collect default network fact
+  when: "'default_ipv4' not in ansible_facts"
   ansible.builtin.setup:
     gather_subset:
       - '!all'

roles/edpm_ovn/tasks/install.yml

@@ -29,7 +29,7 @@
 
 - name: Gather SELinux fact if needed
   when:
-    - ansible_facts.selinux is undefined
+    - "'selinux' not in ansible_facts"
   ansible.builtin.setup:
     gather_subset:
       - "!all"

roles/edpm_ovn_bgp_agent/tasks/install_ovn.yml

@@ -26,7 +26,7 @@
 
 - name: Gather SELinux fact if needed
   when:
-    - ansible_facts.selinux is undefined
+    - "'selinux' not in ansible_facts"
   ansible.builtin.setup:
     gather_subset:
       - "!all"

roles/edpm_podman/tasks/install.yml

@@ -28,7 +28,7 @@
 
     - name: Ensure we get the ansible interfaces facts
       when:
-        - ansible_facts['interfaces'] is undefined
+        - "'interfaces' not in ansible_facts"
       ansible.builtin.setup:
         gather_subset:
           - '!all'

roles/edpm_ssh_known_hosts/tasks/main.yml

@@ -47,6 +47,10 @@
         - _ssh_known_hosts.stat.exists | bool
 
     - name: Gather facts if they don't exist
+      when:
+        - ("'ssh_host_key_rsa_public' not in ansible_facts") or
+          ("'ssh_host_key_ed25519_public' not in ansible_facts") or
+          ("'ssh_host_key_ecdsa_public' not in ansible_facts")
       ansible.builtin.setup:
         gather_subset:
           - "!all"