Implement predictable IP generation for miniDNS #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we had the rndc secret mounted on the worker pods, but any change to the existing secret would not modify the mounted rndc keys. This patch adds the secret's hash to the worker's hash, which will "synchronize" the mounted keys according to the secret's state.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omersch381 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
omersch381
force-pushed
the
add_predict_ips_mdns
branch
from
f587783
to
7bbcb28
Compare
The designate miniDNS needs a predictable IP mechanism, as it is a daemonset and will use the list of available workers to generate a list of IPs that are valid for the designate network attachment's CIDR range but do not overlap with the address range defined in the attachment's IPAM config. This patch adds it.
omersch381
force-pushed
the
add_predict_ips_mdns
branch
from
7bbcb28
to
8cd5bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The designate miniDNS needs a predictable IP mechanism, as it is a
daemonset and will use the list of available workers to generate a list
of IPs that are valid for the designate network attachment's CIDR range
but do not overlap with the address range defined in the attachment's
IPAM config.
This patch adds it.