use the datasources field for the nova dataplane service def #920
Conversation
SeanMooney
requested review from
slagle and
gibizer
and removed request for
slagle
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SeanMooney The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The default nova dataplane service now supports an optional nova-extra-config configmap This change removes the creation of the custom service but keeps the creation fo the nova-extra-config configmap Depends-On: openstack-k8s-operators/dataplane-operator#920 Related: OSPRH-6407
|
looks like i need to update one of the env tests but ill leave the rest run to completion before i rebase |
|
actully that passed locally... so ill retrigger that job. i guess its a flaky test. |
|
/test functional |
config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml
Outdated
Show resolved
Hide resolved
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b88aba456a2149d6aa43d4cb7d46b6f7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 39s |
SeanMooney
force-pushed
the
use-datasources-for-nova
branch
from
6613c96
to
bb8f47f
Compare
config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml
Outdated
Show resolved
Hide resolved
config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml
Outdated
Show resolved
Hide resolved
SeanMooney
force-pushed
the
use-datasources-for-nova
branch
from
bb8f47f
to
42ec715
Compare
|
/retest-required |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1f7f2a4ce6264f9a8ad6df0d524d2c87 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 42m 32s |
|
I switched the json field name to be |
slagle
force-pushed
the
use-datasources-for-nova
branch
from
42ec715
to
b8451ed
Compare
I updated it, hope you don't mind |
|
/retest |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/453612be3ddb4a9385c5f212a848df80 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 58s |
|
/retest-required |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/5be4e6b3dd6a4f15865d25e5d1c7f92d ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 37m 39s |
| # It should contain an ssh key-pair in the secret fields: ssh-privatekey | ||
| # and ssh-publickey | ||
| - nova-migration-ssh-key | ||
| dataSources: |
There was a problem hiding this comment.
this should wait for the adoption job to CI such sort of changes perhaps (as this will break adoption)
There was a problem hiding this comment.
im not sure it would
we do need to modify the adoption procedure in the future to not create any custom server and just use the standard nova one
in any case i guess we can try and get the adoption procedure updated this week as well
The default nova dataplane service now supports an optional nova-extra-config configmap This change removes the creation of the custom service but keeps the creation fo the nova-extra-config configmap Depends-On: openstack-k8s-operators/dataplane-operator#920 Related: OSPRH-6407
to break a ci depenency we need to carfully sequence our usage of dataSources. pr openstack-k8s-operators#846 broke the ablity for openstack-k8s-operators/dataplane-operator#920 to merge in the dataplane operator by hardcoding a replacement of the datasource in the nova dataplane service with only the custom config. as a result when we move the requried configmaps to the dataSources it overriedes them and resulting in ipam configution failing because the ssh key is not present. this change adapts install yamls to fully transfrom the dataplane service into the new form that will be intoduced in pr#920 then we can remove this temporay mesure once that is merged vai pr openstack-k8s-operators#845 Related: OSPRH-6407
|
check-rdo |
|
/retest-required |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7cb40a1962a248a2a4b9b428ff5c155a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 06s |
SeanMooney
force-pushed
the
use-datasources-for-nova
branch
from
b8451ed
to
9c6a336
Compare
config/services/dataplane_v1beta1_openstackdataplaneservice_nova.yaml
Outdated
Show resolved
Hide resolved
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/31ef6e4b669c4d928c5cb10fc3245c63 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 43s |
This change ports the nova OpenstackDataplaneService to use the recently added datasources field. This allows the default dataplane service to optionally support constom service config via a config called nova-extra-config This name was choosen to aling to the default custom service config used in the ci framework. Related: OSPRH-6407
SeanMooney
force-pushed
the
use-datasources-for-nova
branch
from
9c6a336
to
b0c3e43
Compare
|
As I added this change to openstack-k8s-operators/openstack-operator#765 |
|
@SeanMooney: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/5e17d2e52e89426bb88fdc8eec7e975b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 45s |
This change ports the nova OpenstackDataplaneService to use
the recently added datasources field.
This allows the default dataplane service to optionally support
constom service config via a config called nova-extra-config
This name was choosen to aling to the default custom service
config used in the ci framework.
Related: OSPRH-6407