Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTEROP-7530] Fixes to 4.17 FIPS config for Quay, DevSpaces, MTR. Add slack_reporter config to .config.prowgen files. #56957

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dfrazzette
Copy link
Contributor

  • Update Quay from 3.11 to 3.12 in FIPS config + slack_reporter dictionary in .config.prowgen.
  • Update DevSpaces 4.17 to include FIPS config (overlooked during FIPS PoC testing) + slack_reporter dictionary in .config.prowgen.
  • Correct MTR FIREWATCH_DEFAULT_JIRA_ADDITIONAL_LABELS object syntax + slack_reporter dictionary in .config.prowgen.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@openshift-ci-robot
Copy link
Contributor

@dfrazzette, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@dfrazzette
Copy link
Contributor Author

/pj-rehearse periodic-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.17-lp-interop-mtr-interop-aws-fips periodic-ci-redhat-developer-devspaces-interop-tests-main-devspaces-ocp4.17-lp-interop-devspaces-interop-aws-fips periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-lp-interop-fips

@openshift-ci-robot
Copy link
Contributor

@dfrazzette: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dfrazzette dfrazzette marked this pull request as ready for review September 20, 2024 04:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2024
@dfrazzette
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@dfrazzette: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 20, 2024
`slack_reporter` config to .config.prowgen files.
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@openshift-ci-robot
Copy link
Contributor

@dfrazzette, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfrazzette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 20, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dfrazzette: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-windup-windup-ui-tests-main-image-hack-images windup/windup-ui-tests presubmit Presubmit changed
pull-ci-windup-windup-ui-tests-main-image-hack-use-mtr-runner windup/windup-ui-tests presubmit Presubmit changed
pull-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.14-lp-interop-images windup/windup-ui-tests presubmit Presubmit changed
pull-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.15-lp-interop-images windup/windup-ui-tests presubmit Presubmit changed
pull-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.16-lp-interop-images windup/windup-ui-tests presubmit Presubmit changed
pull-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.17-lp-interop-images windup/windup-ui-tests presubmit Presubmit changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-netappgrid N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay310-ocp417 N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-lp-interop N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-fips N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-azure N/A periodic Periodic changed
periodic-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.14-lp-interop-mtr-interop-ibmcloud N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-lp-interop-fips N/A periodic Periodic changed
periodic-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.17-lp-interop-mtr-interop-aws-fips N/A periodic Periodic changed
periodic-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.17-lp-interop-mtr-interop-aws N/A periodic Periodic changed
periodic-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.16-lp-interop-mtr-interop-aws N/A periodic Periodic changed
periodic-ci-redhat-developer-devspaces-interop-tests-main-devspaces-ocp4.17-lp-interop-devspaces-interop-aws-fips N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-aws-s3 N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-gcp N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay312-ocp417-ibmcos N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-417-quay-quay-e2e-tests-quay311-ocp417 N/A periodic Periodic changed
periodic-ci-windup-windup-ui-tests-v1.2-mtr-ocp4.15-lp-interop-mtr-interop-ibmcloud N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@dfrazzette: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ordered-prow-config a45d451 link true /test ordered-prow-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants