Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7655: Migrate SelectVariant.Typeahead SelectInputFields to PF5 #14305

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

logonoff
Copy link
Member

Fixes:

https://issues.redhat.com/browse/ODC-7655

Solution Description:

Migrate all SelectInputFields that use the typeahead variant to PF5. Other variants will get other PRs as I am splitting up this component

I commented out the input validation UI because it is not supported in our currently installed version of PatternFly

Screen shots / Gifs for design review:

Demo:

Screencast.from.2024-09-17.14-28-14.mp4

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 5/? of ODC-7655 story as each file is being split into a separate PR.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2024

@logonoff: This pull request references ODC-7655 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7655

Solution Description:

Migrate all SelectInputFields that use the typeahead variant to PF5. Other variants will get other PRs as I am splitting up this component

I commented out the input validation UI because it is not supported in our currently installed version of PatternFly

Screen shots / Gifs for design review:

Demo:

Screencast.from.2024-09-17.14-28-14.mp4

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 5/? of ODC-7655 story as each file is being split into a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2024
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Sep 17, 2024
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please assign vikram-raj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please assign vikram-raj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Sep 17, 2024
@logonoff logonoff force-pushed the ODC-7655-SingleTypeaheadField branch 2 times, most recently from 698b49a to f0af6b8 Compare September 19, 2024 15:14
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants