MGMT-18965: Update docker files to use universal base image #905
Conversation
This updates the docker files of this project to use the universal base image
openshift-ci-robot
added
the
jira/valid-reference
|
@paul-maidment: This pull request references MGMT-18965 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.z" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/L
|
/test ? |
|
@paul-maidment: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
downstream-change-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paul-maidment The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-agent-compact-ipv4 |
1 similar comment
|
/test e2e-agent-compact-ipv4 |
|
@paul-maidment: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| ARG TARGETPLATFORM | ||
| ENV GOFLAGS=-mod=mod | ||
| WORKDIR /go/src/github.com/openshift/assisted-installer | ||
|
|
||
| # Workaround for creating build folder |
There was a problem hiding this comment.
Why using a workaround when we can use this image the way it's meant to?
There was a problem hiding this comment.
It's not being used correctly on master?
https://github.com/openshift/assisted-installer/blob/master/Dockerfile.assisted-installer#L7
|
@paul-maidment Can you explain the reasoning for this branch ? |
The 4.16 branch is broken unless we do something, try running
I think moving to UBI would be the correct course of action, consistent with what we did on master to fix the same issue? Were some backports were missed at the time? |
This updates the docker files of this project to use the universal base image