[KNI][release-4.14] nrt: cache: add support for dedicated informer #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This reverts commit 0338ae3.
ffromani
force-pushed
the
sched-informer-4.14
branch
from
57fc9af
to
161d414
Compare
Add an option to create and use a separate informer to get unfiltered pod listing from the apiserver. Due to mismatched view with respect to the kubelet, the plugin needs access to pod in terminal phase which are not deleted to make sure the reconciliation is done correctly. xref: kubernetes-sigs#598 xref: kubernetes/kubernetes#119423 Signed-off-by: Francesco Romani <[email protected]> (cherry picked from commit e466bc4)
ffromani
force-pushed
the
sched-informer-4.14
branch
from
161d414
to
ba793a9
Compare
ffromani
added a commit
that referenced
this pull request
Jul 24, 2024
[release-4.14][manual] revert #223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the KNI-specific support for dedicated informer, and use upstream one.
Add an option to create and use a separate informer
to get unfiltered pod listing from the apiserver.
Due to mismatched view with respect to the kubelet,
the plugin needs access to pod in terminal phase
which are not deleted to make sure the reconciliation
is done correctly.
xref: kubernetes-sigs#598
xref: kubernetes/kubernetes#119423
Signed-off-by: Francesco Romani [email protected]
(cherry picked from commit e466bc4)