Skip to content

Commit

Permalink
[KNI] improve klogr compatibility
Browse files Browse the repository at this point in the history
the klogr wrapper should not serialize args but rather
pass them through, because this is the behavior most similar
to what we will have in 41.6 and onwards.

Signed-off-by: Francesco Romani <[email protected]>
(cherry picked from commit ad71d20)
  • Loading branch information
ffromani committed Jun 20, 2024
1 parent 3b8d5b9 commit 09f93f4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/noderesourcetopology/filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func singleNUMAContainerLevelHandler(pod *v1.Pod, zones topologyv1alpha2.ZoneLis

// subtract the resources requested by the container from the given NUMA.
// this is necessary, so we won't allocate the same resources for the upcoming containers
clh := klogr.New().WithValues("logID", logID, "node", nodeInfo.Node().Name)
clh := klogr.NewWithOptions(klogr.WithFormat(klogr.FormatKlog)).WithValues("logID", logID, "node", nodeInfo.Node().Name)
err := subtractResourcesFromNUMANodeList(clh, nodes, numaID, qos, container.Resources.Requests, logID)
if err != nil {
// this is an internal error which should never happen
Expand Down

0 comments on commit 09f93f4

Please sign in to comment.