Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Update hack/update_deps.sh to handle exported API submodule #230

Merged

Conversation

donpenney
Copy link
Collaborator

The api/hardwaremanagement folder is exported as a submodule for use by the oran-hwmgr-plugin, with its own go.mod and go.sum files. Should anything be changed in the submodule that impacts imports, it is important that the go.mod and go.sum are updated. By extending the hack/update_deps.sh to include a go mod tidy in the subfolder, we ensure that any missing changes are caught by the ci-job test to prevent issues.

@openshift-ci-robot
Copy link
Collaborator

@donpenney: This pull request explicitly references no jira issue.

In response to this:

The api/hardwaremanagement folder is exported as a submodule for use by the oran-hwmgr-plugin, with its own go.mod and go.sum files. Should anything be changed in the submodule that impacts imports, it is important that the go.mod and go.sum are updated. By extending the hack/update_deps.sh to include a go mod tidy in the subfolder, we ensure that any missing changes are caught by the ci-job test to prevent issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tliu2021
Copy link
Collaborator

tliu2021 commented Oct 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@alegacy
Copy link
Contributor

alegacy commented Oct 2, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alegacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 99fb319 into openshift-kni:main Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants