Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upversion golang to 1.22 #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sudomakeinstall2
Copy link

In order to use IBGU for upgrade, TALM should be added as a dependency. Since TALM is using golang1.22, it is required to upversion golang to 1.22.

@sudomakeinstall2 sudomakeinstall2 force-pushed the upversion-golang-1.22 branch 2 times, most recently from 89f2ea5 to 1fe654c Compare October 1, 2024 17:55
Copy link

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jhernand for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@donpenney
Copy link
Collaborator

In order to use IBGU for upgrade, TALM should be added as a dependency.
Since TALM is using golang1.22, it is required to upversion golang to
1.22

Signed-off-by: Saeid Askari <[email protected]>
@sudomakeinstall2
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2024
@donpenney
Copy link
Collaborator

I think https://github.com/openshift-kni/oran-o2ims/blob/main/api/hardwaremanagement/go.mod should probably be updated in this PR as well. In the near future, we should look at creating a check we can include in the ci-job that makes sure this subfolder go.mod aligns with the main one - although that may make it tricky when we add dependbot config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants