Add initial upgrade reconciler #223
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@sudomakeinstall2: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
api/v1alpha1/clusterrequest_types.go
Outdated
| @@ -41,6 +42,8 @@ type ClusterRequestSpec struct { | |||
|
|
|||
| //+operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Timeout",xDescriptors={"urn:alm:descriptor:com.tectonic.ui:text"} | |||
| Timeout Timeout `json:"timeout,omitempty"` | |||
|
|
|||
| SeedImageRef ibuv1.SeedImageRef `json:"seedImageRef,omitempty"` | |||
There was a problem hiding this comment.
This cannot be a top level parameter. It would have to be provided as a template parm, which raises the question do we even expose this of just make a fixed parm of the template version
There was a problem hiding this comment.
Agreed - the seedImageRef will be specified as part of the cluster template and will be fixed for a particular cluster template version - we still need a bit of investigation to figure out the best way to do that.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
Why is this (and the other CRDs) showing up as a new file?
There was a problem hiding this comment.
these are because of the recent group name change. I will remove them.
Signed-off-by: Saeid Askari <[email protected]>
sudomakeinstall2
force-pushed
the
upgrade-reconcile
branch
from
26467ff
to
e290eca
Compare
No description provided.