Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-14658: Replace clusterTemplateRef field with templateName and templateVersion #221

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

Missxiaoguo
Copy link
Collaborator

  • Replace clusterTemplateRef with two new fields - templateName and templateVersion, which represent the referenced ClusterTemplate.
  • The name of ClusterTemplate should be formatted as <templateName.templateVersion>

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 26, 2024

@Missxiaoguo: This pull request references CNF-14658 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

  • Replace clusterTemplateRef with two new fields - templateName and templateVersion, which represent the referenced ClusterTemplate.
  • The name of ClusterTemplate should be formatted as <templateName.templateVersion>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Missxiaoguo Missxiaoguo force-pushed the clusterrequest branch 2 times, most recently from 03b3486 to a154231 Compare September 26, 2024 19:43
@bartwensley
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@irinamihai
Copy link
Collaborator

/approve

Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irinamihai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@bartwensley
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a052f08 into openshift-kni:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants