CNF-14440: scorecard tests failing #206
Conversation
irinamihai
requested review from
Missxiaoguo,
alegacy,
donpenney and
tliu2021
|
@irinamihai: This pull request references CNF-14440 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
api/v1alpha1/inventory_types.go
Outdated
| DeploymentServerStatus string `json:"deploymentServerStatus,omitempty"` | ||
| // +operator-sdk:csv:customresourcedefinitions:type=status,displayName="Metadata Server Status" | ||
| // +operator-sdk:csv:customresourcedefinitions:type=status,displayName="MetadataServer tatus" |
irinamihai
force-pushed
the
scorecard-2
branch
3 times, most recently
from
aaa0e55
to
94e93a3
Compare
| //+kubebuilder:rbac:groups=oran.openshift.io,resources=orano2imses,verbs=get;list;watch;create;update;patch;delete | ||
| //+kubebuilder:rbac:groups=oran.openshift.io,resources=orano2imses/status,verbs=get;update;patch | ||
| //+kubebuilder:rbac:groups=oran.openshift.io,resources=orano2imses/finalizers,verbs=update | ||
| //+kubebuilder:rbac:groups=oran.openshift.io,resources=Inventoryes,verbs=get;list;watch;create;update;patch;delete |
There was a problem hiding this comment.
The plural of inventory should be inventories, no?
config/rbac/role.yaml
Outdated
| @@ -155,7 +155,7 @@ rules: | |||
| - apiGroups: | |||
| - oran.openshift.io | |||
| resources: | |||
| - clusterrequests | |||
| - Inventoryes | |||
There was a problem hiding this comment.
Inventoryes -> Inventories?
There was a problem hiding this comment.
Updated in the latest patch. Thank you!
irinamihai
force-pushed
the
scorecard-2
branch
from
94e93a3
to
355eee8
Compare
api/v1alpha1/inventory_types.go
Outdated
| IngressHost string `json:"ingressHost,omitempty"` | ||
| } | ||
|
|
||
| type DeploymentsStatus struct { | ||
| // +operator-sdk:csv:customresourcedefinitions:type=status,displayName="Deployment Server Status" | ||
| // +operator-sdk:csv:customresourcedefinitions:type=status,displayName="DeploymentServerStatus" |
There was a problem hiding this comment.
Shouldn't the spaces in the displayName be preserved? Isn't this used in UI elements for end users?
There was a problem hiding this comment.
I used TALM as an example which uses both ways, so I've decided to go with no spaces. I can change all of them to include spaces.
| //+kubebuilder:rbac:groups=oran.openshift.io,resources=orano2imses/finalizers,verbs=update | ||
| //+kubebuilder:rbac:groups=oran.openshift.io,resources=Inventories,verbs=get;list;watch;create;update;patch;delete | ||
| //+kubebuilder:rbac:groups=oran.openshift.io,resources=Inventories/status,verbs=get;update;patch | ||
| //+kubebuilder:rbac:groups=oran.openshift.io,resources=Inventories/finalizers,verbs=update |
There was a problem hiding this comment.
Should this be "inventories"?
|
/lgtm |
Description: - add spec descriptor - add resources to CRDs - rename ORANO2IMS to Inventory to make bundle building happy - adjust the groups and domains to match with the GVK
irinamihai
force-pushed
the
scorecard-2
branch
from
355eee8
to
095a7dc
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Missxiaoguo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Update test plugin to align with the following PRs: openshift-kni/oran-o2ims#206 openshift-kni/oran-o2ims#209 Signed-off-by: Don Penney <[email protected]>
Description: