CNF-14537: Ensure Cluster deploy and config status check on input issues during resource preparation #205
Conversation
|
@Missxiaoguo: This pull request references CNF-14537 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Missxiaoguo
changed the title
| t.object.Status.ClusterInstanceRef.Name = clusterInstance.GetName() | ||
| } | ||
|
|
||
| // Continune checking the existing ClusterInstance provision status |
…resource preparation Currently, invalid configuration input causes resource preparation to fail, stopping the controller reconciliation. However, if Cluster deployment resources (NodePool, ClusterInstance, or Policies) have already been created and are in progress, subsequent invalid configuration changes should not prevent the controller from continuing to track the current Cluster deployment status. This update ensures that the controller checks the Cluster deploy and config status when an input issue occurs during resource preparation before stopping reconciliation. Unittests are added for ClusterRequest controller reconciliation to verify desired conditions.
Missxiaoguo
force-pushed
the
track_status_on_error
branch
from
4a02f40
to
d7d992f
Compare
|
/lgtm |
Missxiaoguo
changed the title
|
@Missxiaoguo: This pull request references CNF-14537 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irinamihai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Currently, invalid configuration input causes resource preparation to fail, stopping the controller reconciliation. However, if Cluster deployment resources (NodePool, ClusterInstance, or Policies) have already been created and are in progress, subsequent invalid configuration changes should not prevent the controller from continuing to track the current Cluster deployment status.
This update ensures that the controller checks the Cluster deploy and config status when an input issue occurs during resource preparation before stopping reconciliation.
Unittests are added for ClusterRequest controller reconciliation to verify desired conditions.