Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-14440: Fix scorecard errors and cleanup unused files #204

Merged
merged 1 commit into from
Sep 16, 2024
Merged

CNF-14440: Fix scorecard errors and cleanup unused files #204

merged 1 commit into from
Sep 16, 2024

Conversation

irinamihai
Copy link
Collaborator

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2024 •
edited by openshift-ci bot
Loading

@irinamihai: This pull request references CNF-14440 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

/cc @donpenney @Missxiaoguo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@irinamihai irinamihai requested review from tliu2021, donpenney, Missxiaoguo and alegacy and removed request for Missxiaoguo and donpenney September 16, 2024 19:04
@donpenney
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Missxiaoguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6a363d3 into openshift-kni:main Sep 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Missxiaoguo Missxiaoguo Missxiaoguo approved these changes

@tliu2021 tliu2021 Awaiting requested review from tliu2021

@donpenney donpenney Awaiting requested review from donpenney

@alegacy alegacy Awaiting requested review from alegacy

Assignees

@Missxiaoguo Missxiaoguo

@donpenney donpenney

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irinamihai @openshift-ci-robot @donpenney @Missxiaoguo