Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-13593: Update OWNERS to add midstream reviewers for Dockerfile and CSV changes #184

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

leo8a
Copy link
Contributor

@leo8a leo8a commented Aug 28, 2024

@openshift-ci openshift-ci bot requested a review from donpenney August 28, 2024 11:04
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 28, 2024

@leo8a: This pull request references CNF-13593 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

/cc @rauhersu @fontivan @donpenney

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leo8a
Copy link
Contributor Author

leo8a commented Aug 28, 2024

updated only for ^Dockerfiles given that we plan to drop ^Containerfiles soon

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney, rauhersu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fd95b7d into openshift-kni:main Aug 29, 2024
8 checks passed
@leo8a leo8a deleted the midstream-reviewers branch August 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants